Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sector column in the Recent Wins #342

Open
4 of 9 tasks
amughal opened this issue Dec 9, 2024 · 1 comment
Open
4 of 9 tasks

Add Sector column in the Recent Wins #342

amughal opened this issue Dec 9, 2024 · 1 comment

Comments

@amughal
Copy link

amughal commented Dec 9, 2024

Checklist

  • This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue.
  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the Curio forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated feature request to propose.

Curio component

  • PoRep Pipeline
  • Snap Deals
  • Market
  • IPNI provider
  • Curio UI
  • Other

What is the motivation behind this feature request? Is your feature request related to a problem? Please describe.

Loosing block rewards for an SP operations is very costly. With more reliance on the Curio dashboard, I am looking for an easy to debug solution from the dashboard that can quickly Alert, and provide a guidance to debug what went wrong for this lost block reward.

Describe the solution you'd like

Add a Sector column in the Recent Wins. This will allow to trace if a particular storage appliance hosting this sector has slowness issues.
Replace the label "Not Included", with 1) "Slow Computation" or 2) "Orphan Block"

There can be other situations in the above list.

Describe alternatives you've considered

No response

Additional context

No response

@LexLuthr
Copy link
Contributor

LexLuthr commented Jan 7, 2025

I think this issue is incorrectly articulated.

The core problem is that we need to know why we failed to successfully mine a block if we won the ticket.
Looking at the code I see 2 possible reasons:

  1. We failed to calculate and submit a block. This is recorded as a task failure along with the reason.
  2. We submitted a block to the daemon but it was still not included in the tipset.

For the first situation, there is an easy fix, we can display the error in webUI for why a task failed.

For second, this is far more complex and at best we can only guess things based on https://spec.filecoin.io/#section-systems.filecoin_blockchain.struct.block.block-semantic-validation. I am not sure we can validate the block on Curio side. Best we can probably do is run a inclusion check which we already do. @magik6k Any ideas if we can cover all validation? Or maybe something that can be implemented on Lotus side which can later be queried by Curio?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants