-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: monorepo #71
Comments
The problem is how to get the source for different version of |
Yeah, it is not mandatory - but hey, I must have fun doing OSS (and I almost forgot it), so I used it and I'm using it for checking out the PR locally.
I think if we try to propose this, we will get a lot of NO because:
I bet on it - and I quite agree with these sentences.
I know that pain, but I think this is a nice example of what you get at work: odd specifications, and you (as a developer) must do something that works 😄 So I see it as a good gym. In general:
For this reason, I took the responsibility of completing this website migration, otherwise, nobody else would see the value of dealing with all these So, I think the monorepo is impossible and will be impossible. What I think is that after completing the first project migration, there will be opportunities to build the future and propose disruptive things such as:
we have so many options, but we must gain trust first. |
Prerequisites
🚀 Feature Proposal
Have we considered combining the Fastify documentation site with the main Fastify package as a monorepo?
Motivation
Currently the Fastify repo contains the documentation source, while this repo contains the website source code. This (in my opinion) adds a considerable amount of overhead and difficulty for new contributors. For example, requiring the
gh
utility to be installed and setup struck me as unusual for a documentation site. As the original creator of this repo it took me longer than I'd expect to get to a point where I could preview the site in my browser (admittedly I'm sure that can improve without a monorepo).I think it would be great if the markdown for the documentation, the website source code, and the core fastify code could all be located together. It could make getting started, previewing changes, and managing PR's more streamlined.
I'm certain I'm missing something here which would present a challenge. Very curious to hear thoughts.
Example
I setup a simple (incomplete) example in one of my repos over at https://github.com/hello-pangea/color-picker. It's built using turborepo.
The text was updated successfully, but these errors were encountered: