Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling and CI for code quality #131

Open
mk-mxp opened this issue Aug 11, 2024 · 1 comment
Open

Tooling and CI for code quality #131

mk-mxp opened this issue Aug 11, 2024 · 1 comment

Comments

@mk-mxp
Copy link
Contributor

mk-mxp commented Aug 11, 2024

With #130 we now have a "production" build process for the Docker image. And can add a "development" build process to CI, including all the tooling we love in PHP world:

  • code styling (PHP CodeSniffer or php-cs? PSR-12 or PER?)
  • PHPStan, Psalm and/or Phan
  • additional unit testing, mutation testing
  • etc.
@mk-mxp
Copy link
Contributor Author

mk-mxp commented Aug 11, 2024

Make use of assert during CI runs. See #130 (comment) for reasoning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant