From 681a38737da79f5b6d28d8c7960c880db2eb6044 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Mon, 6 Jan 2025 00:51:01 +0530 Subject: [PATCH] Updating tests for change --- exercises/practice/change/.meta/config.json | 1 + exercises/practice/change/.meta/tests.toml | 19 ++++++++++++++++--- exercises/practice/change/change.spec.js | 6 ++++++ 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/exercises/practice/change/.meta/config.json b/exercises/practice/change/.meta/config.json index 08d9faaa50..1b2d266e3f 100644 --- a/exercises/practice/change/.meta/config.json +++ b/exercises/practice/change/.meta/config.json @@ -4,6 +4,7 @@ ], "contributors": [ "adamxtokyo", + "jagdish-15", "rchavarria", "SleeplessByte", "tejasbubane", diff --git a/exercises/practice/change/.meta/tests.toml b/exercises/practice/change/.meta/tests.toml index 6d36d3c760..2d2f44bc21 100644 --- a/exercises/practice/change/.meta/tests.toml +++ b/exercises/practice/change/.meta/tests.toml @@ -1,6 +1,16 @@ -# This is an auto-generated file. Regular comments will be removed when this -# file is regenerated. Regenerating will not touch any manually added keys, -# so comments can be added in a "comment" key. +# This is an auto-generated file. +# +# Regenerating this file via `configlet sync` will: +# - Recreate every `description` key/value pair +# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications +# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion) +# - Preserve any other key/value pair +# +# As user-added comments (using the # character) will be removed when this file +# is regenerated, comments can be added via a `comment` key. + +[d0ebd0e1-9d27-4609-a654-df5c0ba1d83a] +description = "change for 1 cent" [36887bea-7f92-4a9c-b0cc-c0e886b3ecc8] description = "single coin change" @@ -23,6 +33,9 @@ description = "possible change without unit coins available" [9a166411-d35d-4f7f-a007-6724ac266178] description = "another possible change without unit coins available" +[ce0f80d5-51c3-469d-818c-3e69dbd25f75] +description = "a greedy approach is not optimal" + [bbbcc154-e9e9-4209-a4db-dd6d81ec26bb] description = "no coins make 0 change" diff --git a/exercises/practice/change/change.spec.js b/exercises/practice/change/change.spec.js index b7f398e2f1..8dbc425d12 100644 --- a/exercises/practice/change/change.spec.js +++ b/exercises/practice/change/change.spec.js @@ -54,6 +54,12 @@ describe('Change', () => { expect(result).toEqual([4, 4, 4, 5, 5, 5]); }); + xtest('a greedy approach is not optimal', () => { + const change = new Change(); + const result = change.calculate([1, 10, 11], 20); + expect(result).toEqual([10, 10]); + }); + xtest('no coins make 0 change', () => { const change = new Change(); const result = change.calculate([1, 5, 10, 21, 25], 0);