From 65f9421ab57f9a9096b909f5ee4679becfed594a Mon Sep 17 00:00:00 2001
From: VidhuSarwal <vidhusarwal@hotmail.com>
Date: Sat, 21 Dec 2024 15:36:53 +0530
Subject: [PATCH] Changed return type of ValidateAndReturnVisualize to return
the entire results struct
---
tests/robustness/validate/validate.go | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/robustness/validate/validate.go b/tests/robustness/validate/validate.go
index 0c52ca6267a..a17fc2f467b 100644
--- a/tests/robustness/validate/validate.go
+++ b/tests/robustness/validate/validate.go
@@ -28,8 +28,7 @@ import (
"go.etcd.io/etcd/tests/v3/robustness/report"
)
-// ValidateAndReturnVisualize returns visualize as porcupine.linearizationInfo used to generate visualization is private.
-func ValidateAndReturnVisualize(t *testing.T, lg *zap.Logger, cfg Config, reports []report.ClientReport, persistedRequests []model.EtcdRequest, timeout time.Duration) (visualize func(basepath string) error) {
+func ValidateAndReturnVisualize(t *testing.T, lg *zap.Logger, cfg Config, reports []report.ClientReport, persistedRequests []model.EtcdRequest, timeout time.Duration) Results {
err := checkValidationAssumptions(reports, persistedRequests)
require.NoErrorf(t, err, "Broken validation assumptions")
linearizableOperations := patchLinearizableOperations(reports, persistedRequests)
@@ -38,7 +37,7 @@ func ValidateAndReturnVisualize(t *testing.T, lg *zap.Logger, cfg Config, report
linearizable, results := validateLinearizableOperationsAndVisualize(lg, linearizableOperations, timeout)
if linearizable != porcupine.Ok {
t.Error("Failed linearization, skipping further validation")
- return results.Visualize
+ return results
}
// TODO: Use requests from linearization for replay.
@@ -52,7 +51,7 @@ func ValidateAndReturnVisualize(t *testing.T, lg *zap.Logger, cfg Config, report
if err != nil {
t.Errorf("Failed validating serializable operations, err: %s", err)
}
- return results.Visualize
+ return results
}
type Config struct {