Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Button> Continuity #24

Open
luukee opened this issue Jun 3, 2024 · 2 comments
Open

<Button> Continuity #24

luukee opened this issue Jun 3, 2024 · 2 comments
Labels
design Make the product look better!

Comments

@luukee
Copy link
Contributor

luukee commented Jun 3, 2024

All buttons across the app need to be the Material Tailwind style button. Could be a regular button, button with icon or outlined button.

Refer to the above links for Material Tailwind docs.

Example (see this commit for code):

<button className={style.button} onClick={handleAddNewAgencyModal}>
  <FaPlus className="text-blue-600 mr-2" size={12}/>
  Add Agency
</button>

should be changed to :

<Button onClick={handleAddNewAgencyModal}>
  <FaPlus size={12} />
  Add Agency
</Button>

Suggestion: Do a codebase search (Shift + Command + F) for: <button. And change each.

@luukee
Copy link
Contributor Author

luukee commented Jun 13, 2024

@risha-van Thanks again for working on this project Risha :) Excited to see!

@luukee luukee added the enhancement New feature or request label Jun 13, 2024
@luukee
Copy link
Contributor Author

luukee commented Jul 17, 2024

@risha-van Have you been able to get a working branch for me to look at? All to say, we should get this polished off to merge into the main branch.

Please let me know, thanks :)

@luukee luukee added design Make the product look better! and removed enhancement New feature or request labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Make the product look better!
Projects
None yet
Development

No branches or pull requests

2 participants