Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agency Admin Verification Issues #19

Open
2 tasks
luukee opened this issue Apr 12, 2024 · 1 comment
Open
2 tasks

Agency Admin Verification Issues #19

luukee opened this issue Apr 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@luukee
Copy link
Contributor

luukee commented Apr 12, 2024

Issue 01

issue-01

SCENARIO: User does not have an account, add them as an agency user.

  1. The user is sent an email (subject: Sign in to MisInfo App requested at [date]) and when the user clicks the link in the email this window appears:

Screenshot 2024-04-12 at 7 29 12 AM
Window after clicking link in (Sign in to MisInfo App requested at [date]_) email

  1. after filling out the form with the original email the user is automatically logged in.
  • The new user has these attributes:

    • An account in Firebase Authentication
    • Agency Admin privileges for the agency
    • A verification email (subject: Verify your email for MisInfo App) in their inbox.
  • The new user does NOT have these attributes:

    • A mobileUsers document in the database (because they have not clicked the verification email in their inbox).

Fix

  • On submission of the form in "Window after clicking link in (Sign in to MisInfo App requested at [date]_) email" they should be shown a "Check your email for the final verification" message.
  • Clicking the link in the final verification email should add them as a document in the mobileUsers collection.

Reasoning:

If the user is automatically logged in they will not go through the final step of verifying their email/account creation on a general user signup (sign up -> click link in confirmation email). This poses an issue because when they come back to their email and see the second verification email it might be expired or they might disregard it all together.

At this time of writing if the user clicks the link in the verification email a mobileUsers document is not created for them.

Since there is no mobileUsers doc for the new user if they create a report it is not attached to any agency or user.

Issue 02

issue-02

SCENARIO:

  • User has auth account
  • User has mobileUsers doc
  • User has been added to an agency
  • Resend link button clicked for their email
  1. Click the "Resend link" button on user's email.
  2. User gets an email (subject: Sign in to MisInfo App requested at [date]) & clicks link
  3. Taken to:

Screenshot 2024-04-12 at 7 29 12 AM
Window after clicking link in (Sign in to MisInfo App requested at [date]_) email

This may not be the best action after clicking the link.

(continued after breakfast...)

@luukee
Copy link
Contributor Author

luukee commented Apr 15, 2024

@julia-elias Since this is not going public should we even have a signup page?

We should instead allow agency admin users to add users to the agency.
On adding the user they agency admin should have the option to add the user as a general user or an agency admin for their agency.

@luukee luukee added the bug Something isn't working label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants