V1 Charts Page

[benparsons]

No description provided.

[pixlwave]

Yeah I think it would be nice to have the vendors ranked. Either most liked and most hated. Or just likes minus hates sorted.

[benparsons]

OK, I'll make a page which just shows that. Can you have a thought on layout

[pixlwave]

Can we do a bar chart using an emoji?

[benparsons]

as in, count (like/hate/like-hate) on the y-axis and the emojis on the x axis? could be fun

[pixlwave]

Something like this:

(F*ck knows how)

[benparsons]

I love the chart! Can be implemented by varying the width of a container
(eg "<div with='xx'>"), then using background-image and background-repeat: repeat-x CSS. Glyph score is now available, can use that?

[benparsons]

So, this is done... somewhat. The basic output is there but it will take more styling to make a really good output. @pixlwave

[benparsons]

Improvements made. The use of negative glyph scores means we can have something more like this

[benparsons]

Idea: this page should redirect to the same emoji voting page if there is no data. That way it matters less if #16 is still high.

[pixlwave]

Redirect automatically, or display a message saying "Currently there's no voting data for this Emoji, click here to cast the first vote!"

[pixlwave]

Also, this graph doesn't work in Firefox, just shows vendor names with no images either side.

[benparsons]

Works in FF for me - did the images not load? It's just CSS background, shouldn't be any compatibility probs

…

On 9 March 2017 at 12:12, Doug ***@***.***> wrote: Also, this graph doesn't work in Firefox, just shows vendor names with no images either side. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABJHpylQozb4da84GNXydkpJ9Dty5Gk3ks5rj-zJgaJpZM4MC16-> .

-- M +447866867226 / S ben-parsons / T @benparsons / W www.bpulse.co.uk

[benparsons]

And good question on the the redirect, any idea?

[pixlwave]

I'd show the message, otherwise it just appears broken. Could redirect automatically after 10 seconds too.

[pixlwave]

Ok, i refreshed the page that wasn't working (2 hours ago) and it's fine now. Just tried another one which I know had no results before I voted, and it didn't show anything. Presume this is just the data being cached (or updating on a schedule).

[benparsons]

Could be. Should update on request but maybe there is some cache on mongolab's side.

…

On 9 March 2017 at 14:16, Doug ***@***.***> wrote: Ok, i refreshed the page that wasn't working (2 hours ago) and it's fine now. Just tried another one which I know had no results before I voted, and it didn't show anything. Presume this is just the data being cached (or updating on a schedule). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABJHp-0WV-W_MCGHuFnX4v4XDTA8hHtPks5rkAnTgaJpZM4MC16-> .

-- M +447866867226 / S ben-parsons / T @benparsons / W www.bpulse.co.uk

[benparsons]

Made a little cleanup and added a message when there are no votes.
Made a link from the results page to the vote page.

When we are happy with this page, let's link to it from the vote page, and that can be v1.0!

[pixlwave]

Yep agree, only thing we need is for the table to size down when on mobile, then I'm game for v1.0.

Edit: How'd we do that??

[benparsons]

Yeah it's more complex. https://github.com/emojirank/web/blob/master/results.js#L76 this is where the width of the bars is set. What we need is that regardless of the width of the page, a score of 100 is exactly the max width of one of the columns in that table.