Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about global jquery if imported #92

Open
knownasilya opened this issue Sep 28, 2017 · 3 comments
Open

Don't warn about global jquery if imported #92

knownasilya opened this issue Sep 28, 2017 · 3 comments

Comments

@knownasilya
Copy link
Contributor

The new modules rfc has you using jQuery with import $ from 'jquery', but this eslint plugin doesn't handle the fact that the usage isn't via a global.

@trentmwillis
Copy link
Member

I believe the original intent of that rule was to limit jQuery usage to being specifically from Ember.$ to ensure that whatever jQuery was being used was indeed the version supplied by Ember. But, I'm not 100% certain.

@knownasilya
Copy link
Contributor Author

I disabled mine. It could still be useful when transitioning a new app to modules, but is also a red hearing since it returns false positives.

@maciejmyslinski
Copy link

it also complains when doing import { $ } from 'Ember'; 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants