-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExperimentalSpreadProperty nodes break rules #71
Labels
Comments
mwpastore
added a commit
to mwpastore/eslint-plugin-ember-best-practices
that referenced
this issue
Jul 7, 2017
This seems reasonable to me, though thorough test cases would help better confirm. |
mwpastore
added a commit
to mwpastore/eslint-plugin-ember-best-practices
that referenced
this issue
Aug 15, 2017
mwpastore
added a commit
to mwpastore/eslint-plugin-ember-best-practices
that referenced
this issue
Sep 1, 2017
mwpastore
added a commit
to mwpastore/eslint-plugin-ember-best-practices
that referenced
this issue
Sep 21, 2017
mwpastore
added a commit
to mwpastore/eslint-plugin-ember-best-practices
that referenced
this issue
Oct 3, 2017
mwpastore
added a commit
to mwpastore/eslint-plugin-ember-best-practices
that referenced
this issue
Oct 10, 2017
mwpastore
added a commit
to mwpastore/eslint-plugin-ember-best-practices
that referenced
this issue
Nov 8, 2017
mwpastore
added a commit
to mwpastore/eslint-plugin-ember-best-practices
that referenced
this issue
Nov 14, 2017
mwpastore
added a commit
to mwpastore/eslint-plugin-ember-best-practices
that referenced
this issue
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Having ExperimentalSpreadProperty node properties in the tree seems to break at least
no-2.0.0-hooks
andno-side-effect-cp
. The problem seems to be rooted in the assumption that each node property has akey
property, but ExperimentalSpreadProperty node properties have neitherkey
norvalue
properties. Is the fix as simple as modifying these rules to ignore node properties withoutkey
properties?The text was updated successfully, but these errors were encountered: