Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md5sums.txt is always output #32

Open
edbennett opened this issue Aug 23, 2024 · 0 comments
Open

md5sums.txt is always output #32

edbennett opened this issue Aug 23, 2024 · 0 comments

Comments

@edbennett
Copy link

edbennett commented Aug 23, 2024

Even when the -m option is not passed, that file md5sums.txt is still created.

This is because the definition of the -m option uses action="store_true", default=False, while the check in the code uses options.md5 is not None.

Since options.md5 will only ever be True or False, it is always not None, so this check always passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant