Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greedy match or optimal match? #28

Open
sunfangxun opened this issue Nov 28, 2019 · 1 comment
Open

Greedy match or optimal match? #28

sunfangxun opened this issue Nov 28, 2019 · 1 comment
Assignees

Comments

@sunfangxun
Copy link

It seems the matching strategy is greedy instead of optimal.

For example:
grammar = Grammar()
play = AlternativeSet("play", "play the")
something = AlternativeSet("the game", "piano")
play_something = PublicRule("play_something", Sequence(play, something))
grammar.add_rules(play_something)
grammar.compile()

grammar.find_matching_rules("play the game") -- no matching
grammar.find_matching_rules("play the piano") -- matching

I think the sentance "play the game" should match the rule "play""the game".

Can you help to support it? Thanks.

@Danesprite

@drmfinlay
Copy link
Owner

@sunfangxun Thanks for reporting this! I'll see if I can fix it soon.

@drmfinlay drmfinlay self-assigned this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants