You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have setup my digger with Orchectrator backend and auto_merge: true. When issuing digger apply with -p flag, the PR is merged immediately when digger apply completes even though not all the impacted projects are applied.
Reading in the code, it seems the case has only be addressed in backendless mode (purely with cli), in which we do check if all the impacted projects have been applied before merging the PR. But it is not in case of Orchestrator backend, in which we check only if all the newly created jobs associated with the created batch have been applied successfully.
Reproduce:
Setup Digger with backend mode
Add auto_merge: true to digger.yaml file
Create example repo with at least 2 impacted projects
Create PR and run digger apply with -p flag
Expected result:
The mentioned project should be applied successfully, but the PR should not merge yet because not all the impacted projects have been applied
Actual result:
The PR is merged and other impacted projects are not yet applied
I have setup my digger with Orchectrator backend and
auto_merge: true
. When issuingdigger apply
with-p
flag, the PR is merged immediately whendigger apply
completes even though not all the impacted projects are applied.Reading in the code, it seems the case has only be addressed in backendless mode (purely with cli), in which we do check if all the impacted projects have been applied before merging the PR. But it is not in case of Orchestrator backend, in which we check only if all the newly created jobs associated with the created batch have been applied successfully.
Reproduce:
auto_merge: true
todigger.yaml
filedigger apply
with-p
flagExpected result:
Actual result:
Fix:
The text was updated successfully, but these errors were encountered: