Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Java 11 #2375

Open
4 tasks
nedtwigg opened this issue Jan 1, 2025 · 3 comments
Open
4 tasks

Remove support for Java 11 #2375

nedtwigg opened this issue Jan 1, 2025 · 3 comments
Labels

Comments

@nedtwigg
Copy link
Member

nedtwigg commented Jan 1, 2025

Some of our formatters can't compile on Java 11 anymore, so supporting Java 11 at all is getting harder. We'll support it a while longer, but its days are numbered...

Running checklist of todo items to make this happen (please don't send PRs for these at this time, we aren't pulling the plug on Java 11 yet)

nedtwigg added a commit that referenced this issue Jan 1, 2025
…can remove this complexity if we remove support for Java 11 (see #2375)
@nedtwigg
Copy link
Member Author

nedtwigg commented Jan 6, 2025

Not sure why, but on Java 11, JGit was causing this to happen.

- Class `org.eclipse.jgit.util.FS`: external process started '/usr/bin/git --version'
  See https://docs.gradle.org/8.4/userguide/configuration_cache.html#config_cache:requirements:external_processes
- Class `org.eclipse.jgit.util.FS`: external process started '/usr/bin/git config --system --show-origin --list -z'
  See https://docs.gradle.org/8.4/userguide/configuration_cache.html#config_cache:requirements:external_processes

We don't have the problem on Java 17 or later. This hack fixes it

0c66cb0

But it would probably be good to remove it when we bump the minimum Java from 11 to 17.

@nedtwigg
Copy link
Member Author

nedtwigg commented Jan 7, 2025

Another benefit to bumping to Java 17 is that we could use the latest JGit, which adds worktree support.

@nedtwigg
Copy link
Member Author

nedtwigg commented Jan 7, 2025

It would also bump our required version of Gradle to 7.3, which would allow some minor simplifications here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant