Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need a plugin for CKEditor #1466

Closed
mgifford opened this issue Apr 1, 2019 · 3 comments
Closed

We need a plugin for CKEditor #1466

mgifford opened this issue Apr 1, 2019 · 3 comments

Comments

@mgifford
Copy link
Contributor

mgifford commented Apr 1, 2019

I'm cross-posting from cksource/ckeditor4-plugin-a11ychecker#242 to hopefully have a new accessibility checker engine brought into the very popular CKEditor.

Would love it if there were more in the aXe community who could help make this a reality.

This is following a tweet from https://twitter.com/dequesystems/status/1112712257195180032

@straker
Copy link
Contributor

straker commented Apr 2, 2019

Hey Mike,

I took a cursory look at this (I'm not very familiar with CKEditor codebase). I figured out how to get axe to run on the editor DOM, but after that point I'm not sure what would need to be done.

Since axe will mostly only run on visible nodes, all I did was remove the display: none property on contentElement.$ before running axe, then swapped out this line https://github.com/cksource/ckeditor-plugin-a11ychecker/blob/master/EngineQuail.js#L126 for

contentElement.$.style.display = 'block';
axe.run(contentElement.$, function(error, results) {
  contentElement.$.style.display = 'none';
  if (error) throw error;

  // can now look at any violations in `results.violations`
});

After that point, I'm not sure what would need to happen to have the editor look at each violation in turn and make suggestions as it currently does, but hopefully it gets someone started. Happy to answer any questions, possibly continue the conversation in the ckeditor-plugin-a11ychecker tread.

@mgifford
Copy link
Contributor Author

mgifford commented Apr 3, 2019

Thanks so much @straker - I'm also a step removed. I could help with Drupal, but CKEDitor is it's own project. Let me report that back with the CKEditor community and see where this goes.

Thanks for doing some initial testing here!

@straker
Copy link
Contributor

straker commented Apr 10, 2019

Closing this issue and will follow along in the other thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants