-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running zsh in container as a non-root user #27
Comments
You should be able to install the script as a non-root user. See this comment from the README for more info:
|
@deluan this is not to run the Docker script as a non-root user, or access zsh as a non-root, but to install zsh within a non-root user's profile. In other words, consider the scenario where the user does not have access to the root user's home directory. Then the existing script will not work (since the current script stores zsh files within $HOME). I followed the part of the README.md you have shared in my example, where my user didn't have root access, and while the script runs, this still installed zsh within root user in a non-accessible part of the machine. This issue proposed to fix this (and associated PR is opened to solve it). |
I see... Well, keep in mind that the |
Thanks. I've updated test.sh. Notes (for testing purposes only):
In order to solve these I've added two functions to the test suite:
All tests are now passing. |
Current Behavior
The current Oh My Zsh installation script for containers assumes that the user running zsh is root. This limits its flexibility in containerized environments where running as a non-root user is often preferred for security/other reasons.
Proposed Change
Modify the installation script to support running as a non-root user within a container. This would include:
Benefits
Additional Context
This was also requested by another user in the following comment: #23 (comment)
The text was updated successfully, but these errors were encountered: