Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependency in lib/mutate-request.ts > lib/types.ts #1626

Open
Tracked by #1244
samayer12 opened this issue Jan 6, 2025 · 1 comment
Open
Tracked by #1244

Comments

@samayer12
Copy link
Contributor

Describe what should be investigated or refactored

A circular dependency exists between these files. We should refactor our code so that it no longer exists.

It's possible that there will be a chain of related circular dependencies while working on this issue, try to scope work down to just the specified files if possible. If not possible, cross-reference to other circular dependency issues.

Links to any relevant code

N/A

Additional context

Run npx madge --circular --ts-config tsconfig.json --extensions ts,js src/ to check for circular dependencies locally.

@cmwylie19 cmwylie19 self-assigned this Jan 8, 2025
@cmwylie19 cmwylie19 moved this from 🆕 New to 🏗 In progress in Pepr Project Board Jan 8, 2025
@cmwylie19 cmwylie19 moved this from 🏗 In progress to 📋 Backlog in Pepr Project Board Jan 15, 2025
@cmwylie19
Copy link
Contributor

cmwylie19 commented Jan 15, 2025

Lots of churn with other circular dependency work right now. Putting this aside to address a build issue which is blocking CI work

@cmwylie19 cmwylie19 removed their assignment Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants