Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variants disabled still appears in rich_snippets #71

Open
cbastienbaron opened this issue Jul 3, 2024 · 0 comments
Open

Variants disabled still appears in rich_snippets #71

cbastienbaron opened this issue Jul 3, 2024 · 0 comments

Comments

@cbastienbaron
Copy link
Contributor

cbastienbaron commented Jul 3, 2024

Hi 🖖 ,

First, thanks guys for this plugin, thats save hours of life :)

now the issue :

Seems when a variant is disabled, he's still appears in the block

<!-- BEGIN BLOCK | event name: "dedi_sylius_seo_plugin.rich_snippets", block name: "dedi_seo_metatags", template: "@DediSyliusSEOPlugin/Shop/Header/_richSnippets.html.twig", priority: 0 -->

<script type="application/ld+json">[{"@context":"https://schema.org","@type":"Product","name":"Product","description":null,"gtin13":"7610137298367","offers":[
{
"@type":"Offer",
"url":"http://127.0.0.1/fr_FR/products/test-1017",
"priceCurrency":"CHF",
"price":"20.0",
"availability":"https://schema.org/InStock"
},
{
"@type":"Offer","url":"http://127.0.0.1/fr_FR/products/test-1017",
"priceCurrency":"CHF",
"price":"5.9",
"availability":"https://schema.org/InStock"
} // <== We dont want u, u r disabled

]}]</script> 

here, there is only one variant enable for this product (the second is disable, and must not appears on product page). There is a config for this ? or need a pr to fix this ?

cbastienbaron added a commit to cbastienbaron/sylius-seo-plugin that referenced this issue Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant