Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spec text: "... Messages MUST be committed to an IPLD DAG in a tree allocated to the DID of the owner ..." #261

Open
thehenrytsai opened this issue Aug 24, 2023 · 3 comments
Assignees
Labels
artifact: spec intended for the actual specification attr: alignment-effort part of the alignment efforts

Comments

@thehenrytsai
Copy link
Contributor

thehenrytsai commented Aug 24, 2023

In order to enable data replication features for a Decentralized Web Node, all Messages MUST be committed to an IPLD DAG in a tree allocated to the DID of the owner after all subtrees are composed and committed. The top-level of Message objects MUST be committed as a DAG CBOR encoded object.

The above text is outdated especially the first sentence. The word "committed" is ambiguous in "... MUST be committed as a DAG CBOR", I read it as "it must be stored as DAG CBOR", but that's not cace, we only use IPLD DAG CBOR/PB for generating CIDs.

We need to update or remove this text.

@LiranCohen LiranCohen added attr: alignment-effort part of the alignment efforts artifact: spec intended for the actual specification labels Aug 24, 2023
@LiranCohen
Copy link
Member

Thanks for pointing this out @thehenrytsai.

I think this entire Messages section needs updating, but the IPLD stuff definitely needs to be pulled and probably only referenced specifically where the CIDs are generated.

We'll try to get this updated for next call.

@WriterZephos
Copy link

WriterZephos commented Aug 25, 2023

What do you mean when you say we only use IPLD for generating CIDs? Are you saying we put data into IPLD format just for generating CIDs, but it doesn't matter how we actually store the data assuming we can still identify what data a CID points to?

If that's the case, it seems odd that we would go through all that work and not store the data that way. Also, if this is a correct interpretation, how do the current DWN libraries store data and make it so it can be referenced by CID?

@andorsk
Copy link
Collaborator

andorsk commented Sep 20, 2023

Discussed this at DIF:

  • Rationale for CID was for mainly enabling better content recovery over IPFS network without relying on a DWN,
  • IPLD was another benefit.

Assigning to @LiranCohen to respond in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact: spec intended for the actual specification attr: alignment-effort part of the alignment efforts
Projects
None yet
Development

No branches or pull requests

4 participants