Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Webhook signature check failed as error #314

Closed
mdresoled opened this issue Nov 15, 2024 · 2 comments
Closed

Log Webhook signature check failed as error #314

mdresoled opened this issue Nov 15, 2024 · 2 comments

Comments

@mdresoled
Copy link

Description

If a webhook fails, I believe it should be classed as an error and logged as such.

Steps to reproduce

  1. Trigger a webhook

If the webhook signature fails, it returns OK, and is logged as a warning.

2024-11-15 22:15:34 [web.WARNING] [stripe] Webhook signature check failed: No signatures found matching the expected signature for payload {"memory":2096256} 

Additional info

  • Craft CMS version: 5.5.0.1
  • Stripe for Craft Commerce version: 5.2.4
  • PHP version: 8.3.13
  • Database driver & version: PostgreSQL 16.0
  • Plugins & versions: 5.0.4.3
Copy link

linear bot commented Nov 15, 2024

@lukeholder
Copy link
Member

Thanks for reporting this. I have fixed it for the next release.

To get the fix early, change your craftcms/commerce requirement in composer.json to:

"require": {
  "craftcms/commerce-stripe": "5.x-dev#4dc41cc91011d4e7f51f61210a87de7619869dd4 as 5.0.44",
  "...": "..."
}

Then run composer update.

We will update this ticket once the release is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants