Testing the file should-fail-self-hardlink.dump fails with mkcomposefs: Invalid embedded NUL character at position 22

[eriksjolund]

I tried e2afe90

# mkcomposefs --from-file composefs/tests/assets/should-fail-self-hardlink.dump resultfile
mkcomposefs: Invalid embedded NUL character at position 22

I had expected to see some error message starting with mkcomposefs: Self-referential hardlink
because of the filename should-fail-self-hardlink.dump

[cgwalters]

Thanks for trying this out! Fix in #374

However, what would clearly be better here is to enhance the test suite to have a notion of "expected error"...which would be nicer to do if we supported comments in dumpfiles (maybe with an opt-in for new syntax) and then our test suite could embed the expected error like:

# expect: Self-referential hardlink
/ 4096 40555 2 0 0 0 0.0 - - - 
/037blockdev 0 @63340777 2 0 0 0 0.0 /037blockdev - -

or so.