-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-merge jobs failing #708
Comments
It seems like trustee/.github/workflows/kbs-e2e.yml Line 25 in f026344
|
#687 moved to use 24.04 but it had been like that since |
@mythi , kbs-e2e.yml's |
Building the binaries is here trustee/.github/workflows/kbs-e2e.yml Line 25 in f026344
And the test runs on this
This was working fine before #689 tho which is odd. I looked through the history again and it does seem like that's when the error showed up (although we did have a different problem after #687) |
github is rotating their I assume the self-hosted pool can be configured to use ubuntu 24.04 images, however it's not great that we break compatibility with LTS distros that are still widely used, so I would suggest to the fix the builder images to 22.04 for the time being. |
I'd be OK with that but I'd still like to understand the core problem. Why |
the binaries are not built on self-hosted runners. the self-hosted runners just provide a real TEE runtime environment for the tests. as said above, I would think that bumping the runtime env to 24.04 would probably help, but otoh it's not great that binaries built on the repo will not work on 22.04 runners. Maybe we can also remove this e2e test suite? the workflows are set up to be generic to allow running on a bare-metal TDX or SNP instances, but so far, the only real TEEs that are tested remain Azure CVMs. If we don't plan to extend this, it might be sufficient to have tests on TEE hardware somewhere downstream. |
Let me submit a PR that moves the e2e building back to 22.04. AFAUI, the default |
I think the Azure e2e jobs have been failing ever since #689
Error:
cc @seungukshin @mkulke
The text was updated successfully, but these errors were encountered: