Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on testForkGrouping by default #4419

Open
lihaoyi opened this issue Jan 28, 2025 · 3 comments
Open

Turn on testForkGrouping by default #4419

lihaoyi opened this issue Jan 28, 2025 · 3 comments

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Jan 28, 2025

Small projects probably won't notice the slight increase in overhead with testForkGrouping enabled, while larger projects would benefit substantially from the parallelism. And people can turn it off if necessary.

Mill's been using it since 0.12.0 and it's been pretty robust, probably can make it the default in 0.13.0

@lefou
Copy link
Member

lefou commented Jan 28, 2025

In my larger projects, testForkGrouping increased test time significantly. This is most likely project and hardware specific but I have yet to find the project where this setting results in relevant faster tests on my hardware.

@lihaoyi
Copy link
Member Author

lihaoyi commented Jan 28, 2025

I think it depends on how big your test suite classes are and how long they take to run. If your classes are numerous and fast, then the overhead of spawning JVMs for each one dominates. If they are few and slow, then the overhead is small and the parallelization benefits win out

@lefou
Copy link
Member

lefou commented Jan 28, 2025

It looks to me this should be a runtime setting rather than build script defined, since it may vary for user / machine / use-case and also ideally should not affect any built outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants