[Certora feedback] _getPointer only needs one % 256

[emizzle]

The _getPointer function can reduce the number of % 256's to reduce gas consumption:

Proofs.sol
- function _getPointer(SlotId id, Period period) internal view returns (uint8) {
-   uint256 blockNumber = block.number % 256;
-   // To ensure the pointer does not remain in downtime for many consecutive
-   // periods, for each period increase, move the pointer 67 blocks. We've
-   // chosen a prime number to ensure that we don't get cycles.
-   uint256 periodNumber = (Period.unwrap(period) * 67) % 256;
-   uint256 idOffset = uint256(SlotId.unwrap(id)) % 256;
-   uint256 pointer = (blockNumber + periodNumber + idOffset) % 256;
-   return uint8(pointer);
- }
+ function _getPointer(SlotId id, Period period) internal view returns (uint8) {
+   uint256 blockNumber = block.number;
+   // To ensure the pointer does not remain in downtime for many consecutive
+   // periods, for each period increase, move the pointer 67 blocks. We've
+   // chosen a prime number to ensure that we don't get cycles.
+   uint256 periodNumber = (Period.unwrap(period) * 67);
+   uint256 idOffset = uint256(SlotId.unwrap(id));
+   uint256 pointer = (blockNumber + periodNumber + idOffset) % 256;
+   return uint8(pointer);
+ }

[markspanbroek]

I would not do that, doing modulo twice was on purpose. A SlotId is the result of a hash. It can be anywhere in the uint256 range. Also at the very end. This could lead to an overflow when adding the blockNumber and periodNumber to it.