Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructor view #108

Open
ashwinvis opened this issue Jan 16, 2025 · 11 comments
Open

Instructor view #108

ashwinvis opened this issue Jan 16, 2025 · 11 comments

Comments

@ashwinvis
Copy link
Contributor

One good thing about the carpentries workbench generator is that you get an instructor view, where directives such as instructor and break are obscured from the learner view.

This can be nice to have. So the questions which remain are:

  • do we want this?
  • how does one implement this in sphinx

Example

One selects it from the top-right corner

Comparison

Learner view Instructor view
Link Link
image image
@ashwinvis
Copy link
Contributor Author

It might be possible to add a custom HTML builder which generates the instructor view.

@samumantha
Copy link

This is indeed nice.

We have the instructor guide as separate page or sometimes as visible boxes in the materials, I guess there was some decision as to why that is so earlier in the development?

@bast
Copy link
Member

bast commented Feb 3, 2025

There is an advantage of having the instructor note rendered in the page of the material. When preparing the lesson, instructors are less likely to overlook it and more likely to keep it up-to-date. The separate pages have suffered from being overlooked and outdated.

@ashwinvis
Copy link
Contributor Author

Another advantage is that inline tips easily show the context.

@ashwinvis
Copy link
Contributor Author

I thought of something... in RTD you can have latest and stable versions side by side. If we call them learner and instructor instead it will work.

We might be able to acheive it without RTD using something like:

https://sphinx-versions.readthedocs.io/en/latest/

Then add a little CSS to toggle the instructor admonition between the 2 "versions"

@bast
Copy link
Member

bast commented Feb 10, 2025

TIL about sphinx-versions. Thank you!

However, sphinx-versions distinguishes based on branches/tags but we probably want both versions to appear in the same branch and same source code?

@samumantha
Copy link

samumantha commented Feb 11, 2025

To keep things up to date it may be good to have it all in one branch (and maybe even file?) 👍

I wonder how people would use it:

  • as an instructor when preparing for a lesson, it would be good to have it in same text?

  • as a learner you do not want to be distracted by it so it should not be visible (at all)?

  • as a learner it might sometimes be helpful to have access to instructor notes to learn more about the strategy, or when the materials are used for self-learning.

  • as an instructor during teaching you sometimes show the materials page, then it should not be visible to learners to not distract. But especially as a new instructor reminders on things while going through them in class might be good 🤔

If we could have both learner view and instructor guide open in two different windows or the same but separate and scrolling somehow linked, could that help? Ie instructor could have the instructor stuff in not shared part of the screen?

Or might collapsible blocks be a solution (like solutions in exercises?)?

@bast
Copy link
Member

bast commented Feb 11, 2025

I imagined either collapsible blocks or a button/switch which can turn visibility on/off using JavaScript.

@samumantha
Copy link

If I see it right in Ashwins original suggestion the right image also has the instructor notes as collapsible blocks?

Unless someone has time to develop some javascript or other solution to having the button/switch between learner and instructor view, should we start with integrating the instructor notes into the lesson material as collapsible blocks? It is already possible with the current setup, isn't it?

Then we could still implement the switch later?

@bast
Copy link
Member

bast commented Feb 11, 2025

Good plan. My recommendation is that instructor notes are tracked in the same file but then rendered somehow. And collapsible is a good first goal. And the nice thing is that such effort would not be wasted since one can then add a switch or differential rendering later without having to change content.

@ashwinvis
Copy link
Contributor Author

CSS + JavaScript toggle button solution seems doable. I will think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants