Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify purpose of helper.InjectPluginVolume(mutatedPod) call in lifecycle example #6

Open
ringerc opened this issue Jun 25, 2024 · 0 comments

Comments

@ringerc
Copy link
Contributor

ringerc commented Jun 25, 2024

In the lifecycle example code there's a call to helper.InjectPluginVolume(mutatedPod)

This appears to inject a volume into the postgres Pod being managed.

It's unclear from the code why this is done, what use cases it might serve, and what the injected volume actually is. Is it meant to be shared state (a cluster filesystem volume?) between all pods? An empty PV? A scratch data area for the plugin?

It would help to clarify this in both the code where it's invoked and in the doc-comment on the helper method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant