Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mill 0.12 #283

Closed
nightscape opened this issue Nov 1, 2024 · 7 comments
Closed

Support Mill 0.12 #283

nightscape opened this issue Nov 1, 2024 · 7 comments

Comments

@nightscape
Copy link

Hi @ckipp01,

Mill 0.12 has been released not to long ago.
Would it be possible to add support for it?

@ckipp01
Copy link
Owner

ckipp01 commented Nov 10, 2024

Hey @nightscape I'm totally open to it, but I probably won't be working on it myself. I haven't been using Mill lately but I'm open to merging in a pr adding support.

@nightscape
Copy link
Author

Main work is done in ckipp01/mill-github-dependency-graph#172

@zhutmost
Copy link
Contributor

Since the main work is ready, maybe we need to update the version check in this action?

@zhutmost
Copy link
Contributor

@ckipp01 Hi, the version check code still needs to be updated. Or it will throw an error when executed with a mill version of 0.12.

if (trimmedVersion.startsWith('0.10') || trimmedVersion.startsWith('0.11')) {

@ckipp01
Copy link
Owner

ckipp01 commented Jan 22, 2025

Closed via #303.

@ckipp01 ckipp01 closed this as completed Jan 22, 2025
@zhutmost
Copy link
Contributor

@ckipp01 Hi, thanks for your #303. However, my action still failed. The mill version is 0.12.5, as specified by the .mill-version file.

Run ckipp01/mill-dependency-submission@v1
  with:
    token: ***
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/[2](https://github.com/zhutmost/chipmunk/actions/runs/12908586613/job/35994420621#step:6:2)1.0.5-11/x64
    JAVA_HOME_21_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/21.0.5-11/x64
Installing mill...
/usr/bin/curl --create-dirs -sLo mill https://github.com/com-lihaoyi/mill/releases/download/0.12.5/0.12.5
/usr/bin/chmod +x mill
/home/runner/work/chipmunk/chipmunk/mill --no-server --import ivy:io.chris-kipp::mill-github-dependency-graph::0.2.7 io.kipp.mill.github.dependency.graph.Graph/submit
======================== io.kipp.mill.github.dependency.graph.Graph/submit =======================
[68/68] ================== io.kipp.mill.github.dependency.graph.Graph/submit ================== [3](https://github.com/zhutmost/chipmunk/actions/runs/12908586613/job/35994420621#step:6:3)s
java.lang.ClassCastException: class scala.Tuple2 cannot be cast to class scala.Tuple3 (scala.Tuple2 and scala.Tuple3 are in unnamed module of loader 'app')
    mill.resolve.Resolve$.$anonfun$invokeCommand0$1(Resolve.scala:163)
    mill.resolve.Resolve$.$anonfun$invokeCommand0$1$adapted(Resolve.scala:163)
    scala.collection.MapOps$WithFilter.$anonfun$withFilter$1(Map.scala:[4](https://github.com/zhutmost/chipmunk/actions/runs/12908586613/job/35994420621#step:6:4)02)
    scala.collection.MapOps$WithFilter.$anonfun$withFilter$1$adapted(Map.scala:402)
    scala.collection.Iterator$$anon$6.hasNext(Iterator.scala:479)
    scala.collection.Iterator$$anon$10.hasNext(Iterator.scala:601)
    scala.collection.immutable.List.prependedAll(List.scala:1[5](https://github.com/zhutmost/chipmunk/actions/runs/12908586613/job/35994420621#step:6:5)2)
    scala.collection.immutable.List$.from(List.scala:685)
    scala.collection.immutable.List$.from(List.scala:[6](https://github.com/zhutmost/chipmunk/actions/runs/12908586613/job/35994420621#step:6:6)82)
    scala.collection.IterableFactory$Delegate.from(Factory.scala:288)
    scala.collection.immutable.Iterable$.from(Iterable.scala:35)
    scala.collection.immutable.Iterable$.from(Iterable.scala:32)
    scala.collection.IterableOps$WithFilter.flatMap(Iterable.scala:903)
    mill.resolve.Resolve$.invokeCommand0(Resolve.scala:163)
    mill.resolve.Resolve$.$anonfun$instantiateCommand$1(Resolve.scala:14[8](https://github.com/zhutmost/chipmunk/actions/runs/12908586613/job/35994420621#step:6:9))
Error: Error: The process '/home/runner/work/chipmunk/chipmunk/mill' failed with exit code 1

@ckipp01
Copy link
Owner

ckipp01 commented Jan 25, 2025

Thanks for the report @zhutmost. Take a look at com-lihaoyi/mill#4390 as it seems to be what you're hitting on. I think this may need to be taken care of on the Mill side before this is usable by Mill 0.12.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants