Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate voicings.cairo with more voicings #20

Open
caseywescott opened this issue Nov 29, 2024 · 5 comments
Open

Populate voicings.cairo with more voicings #20

caseywescott opened this issue Nov 29, 2024 · 5 comments
Assignees
@emarc99
Labels
enhancement New feature or request ODHack10 OnlyDust Hackathon

Comments

@caseywescott
Copy link
Contributor

https://github.com/cienicera/midi_fun_contract/blob/main/src/midi/voicings.cairo
@caseywescott caseywescott added enhancement New feature or request ODHack10 OnlyDust Hackathon labels Nov 29, 2024
@Supa-mega
Copy link

@caseywescott would like to work on this

@emarc99
Copy link

emarc99 commented Nov 29, 2024

Can I start working on this?
Nice to contribute.

@caseywescott
Copy link
Contributor Author

This project requires music knowledge. @emarc99 - We need as many voicings as we possibly can. Do study up and look up various types of chords and voicings. Reach out to me if you need guidance.

@caseywescott
Copy link
Contributor Author

@Supa-mega There is an octave doubling issue if you know about music and cairo. apply on OD

@emarc99
Copy link

emarc99 commented Dec 2, 2024

Making a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emarc99 emarc99

Labels
enhancement New feature or request ODHack10 OnlyDust Hackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@caseywescott @emarc99 @Supa-mega