Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_harmony_from_array #10

Open
caseywescott opened this issue Nov 25, 2024 · 2 comments
Open

generate_harmony_from_array #10

caseywescott opened this issue Nov 25, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request ODHack10 OnlyDust Hackathon

Comments

@caseywescott
Copy link
Contributor

We want to extend this function to take an array of steps instead of a single step:

fn generate_harmony(self: @Midi, steps: i32, tonic: PitchClass, modes: Modes) -> Midi {

Since we don't know how long the melody we are harmonizing is going to be, loop through the input array of steps over and over until the melody is finished.

@caseywescott caseywescott added enhancement New feature or request ODHack10 OnlyDust Hackathon labels Nov 25, 2024
@Bosun-Josh121
Copy link

I can implement this. Please assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ODHack10 OnlyDust Hackathon
Projects
None yet
Development

No branches or pull requests

3 participants
@caseywescott @Bosun-Josh121 and others