Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize wave generators to handle custom channels #11

Open
3 tasks
tekkac opened this issue Mar 18, 2024 · 9 comments
Open
3 tasks

Generalize wave generators to handle custom channels #11

tekkac opened this issue Mar 18, 2024 · 9 comments
Assignees

Comments

@tekkac
Copy link
Collaborator

tekkac commented Mar 18, 2024

Contributing

  • Go to the Nicera Labs OD Telegram
  • Present yourself and tell us which issue you want to pick
  • Explain shortly how you want to tackle the issue
  • Ask a question if you need some clarity
  • When you're selected you will be assigned to the issue

Description

Generalize all wave generators in utils.cairo so that they handle a custom number of channels
Must handle at least:

  • (current) mono (1 channel)
  • stereo (2 channels, left/right)

Additional Information

[Low Difficulty - Cairo - Medium Priority]

Acceptance Criteria

  • Implement custom channels
  • Write and pass unit tests
  • Generate example files
@tekkac tekkac added the ODHack label Mar 18, 2024
@muheebyusufbaba1
Copy link

Good day, I’ll like to work on this issue

@tekkac
Copy link
Collaborator Author

tekkac commented Mar 18, 2024

Good day, I’ll like to work on this issue

Hi @muheebyusufbaba1, did you join the Telegram channel in the description?

@muheebyusufbaba1
Copy link

Yes I did

@tekkac tekkac assigned tekkac and muheebyusufbaba1 and unassigned tekkac Mar 23, 2024
@rmzlb
Copy link

rmzlb commented Apr 1, 2024

hello @muheebyusufbaba1 any updates ?

@saimeunt
Copy link

saimeunt commented Apr 3, 2024

@rmzlb I'd like to try this one if @muheebyusufbaba1 is no longer interested in working on this.

@rmzlb
Copy link

rmzlb commented Apr 4, 2024

@tekkac I let you change assignment for me it's fine 72 h after notification.

@muheebyusufbaba1
Copy link

Please do assign it to another for now I haven't been feeling too well to finalize it

@tekkac tekkac assigned saimeunt and unassigned muheebyusufbaba1 Apr 4, 2024
@silent-cipher
Copy link
Contributor

@saimeunt, Are you still working on this? If not, I would like to work on this.

@saimeunt
Copy link

@silent-cipher : just drafted a PR, still working on it.

@tekkac tekkac removed the ODHack label Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants