Defaults for @RetainForcedMetrics and @CleanStatsOnly are not correctly configured in the code

[DatabaseJase]

Hello,

The notes in the QDSCacheCleanup stored procedure states that the are the defaults for these parameters are:

-- @RetainForcedMetrics BIT -- Flag to retain metrics for queries having forced plans (provided they are not orphan queries) [Default: 0]
-- @CleanStatsOnly BIT -- Changes the behavior of the clean process so only the stats will be cleaned, but not the plans, queries and queries' texts. [Default: 0]

The stored procedure then declares the variables as 1 meaning that the default is not implemented correctly:

,@RetainForcedMetrics BIT = 1
,@CleanStatsOnly BIT = 1

This took me a while to hunt down as I could not understand why the sp_query_store_reset_exec_stats process was being called.

I suggest that the default should stay declared as 1 and change the comments, this prevents current user base from experiencing unexpected changes in behaviour, but I'll leave that with you to decide since I have overriden the defaults by specifying the value when executing QDSCacheCleanup.

Regards

Jason