Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Single Recording template #3

Open
bobbingwide opened this issue Dec 17, 2024 · 3 comments
Open

Add Single Recording template #3

bobbingwide opened this issue Dec 17, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

Add a template to display a single recording

Requirements

  • Title
  • Recording year / publication date
  • Recording type eg CD, DVD, Vinyl
  • Sleeve notes
  • Artists
  • Featured image
  • Tracks listed by track number showing title and duration
@bobbingwide bobbingwide added the enhancement New feature or request label Dec 17, 2024
@bobbingwide bobbingwide self-assigned this Dec 17, 2024
@bobbingwide
Copy link
Owner Author

The current version has a problem with the display of tracks
when the track's title is long. It causes the duration to wrap as well.
image

Note the '.' before the Recording title ( A Knight's Tale).
This is the hard coded string used in the sb/parent-block for when the recording doesn't have a parent.

bobbingwide added a commit that referenced this issue Jan 6, 2025
bobbingwide added a commit that referenced this issue Jan 6, 2025
@bobbingwide
Copy link
Owner Author

Current screenshot for single-oik-recording template

Image

Added

  • Links to Wikipedia and CoCaCamp - populated if the URL is not blank
  • For recordings which are a collection the track list will be empty
  • This is followed by the oik-sb/children block which shows the recordings
  • For the Box set this is a long list!

@bobbingwide
Copy link
Owner Author

bobbingwide commented Jan 21, 2025

The current version has a problem with the display of tracks when the track's title is long. It causes the duration to wrap as well.

To resolve this issue I changed the display from using a row block to 3-columns; one each for track #, title and duration.
These columns do not stack on mobile.

In the site editor I kept on having to change the meta query values in order to be able to see anything.
Eventually I realised that I could hardcode a value for testing, and append the full stop in the meta value field.
eg. "meta_value":"7046,."

Then I changed the filter function to detect the period in the meta value string rather than just looking for a '.'.
This also fixed a Warning when the $meta_query['value'] field was not set.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant