Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet/transaction notifications: Only a single notification is displayed #853

Open
luke-jr opened this issue Feb 14, 2025 · 0 comments
Open
Labels
Bug Something isn't working

Comments

@luke-jr
Copy link
Member

luke-jr commented Feb 14, 2025

There are actually multiple issues here, at least:

  1. WalletView::processNewTransaction only looks at the first of a batch of inserted rows.
  2. QSystemTrayIcon's X11 implementation (QBalloonTip, internal-only) only allows a single notification, destroying the previous when a new one is shown
  3. Showing possibly hundreds of notifications would be terrible UX

It seems like the GUI should queue notifications at the same "instant" (eg, a new block), and if there's multiple send a summary of them all (number of transactions, total sent, total received/mined). This may require some refactoring work, as notifications currently follow the TransactionTableModel insertion slots.

@luke-jr luke-jr added the Bug Something isn't working label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant