Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss use of git hooks #461

Open
binkley opened this issue Apr 15, 2024 · 1 comment
Open

Discuss use of git hooks #461

binkley opened this issue Apr 15, 2024 · 1 comment
Labels
epic So big in importance and breadth that it is EPIC!

Comments

@binkley
Copy link
Owner

binkley commented Apr 15, 2024

Is this related to #549 in context of a "dev init"?

Do not let quality checks be a speed barrier for red-green-refactor.
Make them a barrier to pushing problems to others.
Discuss breaking up the build to hasten cycle time.

  1. Diagram for steps in a build, local and CI.
  2. Leverage git hooks (local or in CI) to stop problems from spreading.
  3. Find usable red-green-refactor cycle image for this section.
  4. Include discussion of Gradle and Maven plugins to auto-create hooks for you.

Update this page: https://github.com/binkley/modern-java-practices/wiki/Cycle-time and integrate with other pages.
Is this a good place for this reference? http://www.extremeprogramming.org/ <-- May be better in introduction? In a "Why this book" section?

ref:

@binkley binkley added the documentation Improvements or additions to documentation label Apr 15, 2024
@binkley binkley moved this to Backlog in @binkley's Modern Build Apr 15, 2024
@binkley binkley moved this from Backlog to Ready in @binkley's Modern Build Apr 16, 2024
@binkley binkley moved this from Ready to In progress in @binkley's Modern Build Apr 16, 2024
@binkley binkley self-assigned this Apr 16, 2024
@binkley
Copy link
Owner Author

binkley commented May 21, 2024

@jwlibby Talk about what moves to CI.

The book should offer options and let the team pick.
Discuss tradeoffs on speed for red-green-refactor vs local quality.
Key is that all these issues are fixed before push to share with others.

Examples:

  • Checkstyle on pre-push, not on commit
  • Mutation testing (PIT) on pre-push, not on commit
  • How to automatically fix style issues in Java? (Kotlin ktlint does this)
  • Call out IDE settings

@binkley binkley moved this from In progress to Ready in @binkley's Modern Build May 21, 2024
@binkley binkley moved this from Ready to Backlog in @binkley's Modern Build May 21, 2024
@binkley binkley removed their assignment May 21, 2024
@binkley binkley changed the title Show red-green-refactor cycle vs git push Discuss use of git hooks May 24, 2024
@binkley binkley removed the documentation Improvements or additions to documentation label May 24, 2024
@jwlibby jwlibby added the epic So big in importance and breadth that it is EPIC! label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic So big in importance and breadth that it is EPIC!
Projects
Status: No status
Development

No branches or pull requests

2 participants