-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help satisfy gMock tests #174
Comments
The test failures all relate to MP3 decoding, so relate to libmad. For the tests to pass, libmad has to produce the exact same output audio, sample by sample, as it does on my Ubuntu system. I'm not sure why the differences occur though. To disable the MP3 tests you could pass a flag to audiowaveform_tests:
As an aside, looking at your Dockerfile you seem to be building the current development version of each dependency, which could lead to unpredictable results. I recommend only using stable release versions. For comparison here are the Dockerfiles I use to cross-compile for Windows. This explains the C++14 issue you found, as I use GoogleTest 1.12.1:
|
Thanks for the concise reply, @chrisn! A wild guess from Libera/#alpine-linux:
Wondering if patching the tests to ensure consistent results or ignoring mp3 tests altogether would be better. Agree that development versions of dependencies can be unpredictable, thinking of releasing a stable tag at some point. |
I'd prefer to figure out how to make the tests consistent. That could mean comparing outputs against platform-specific expected output files or introducing a tolerance. |
Recently
audiowaveform
was failing to build insideaudiowaveform-docker
's Dockerfile because of illegal cxx syntax. Building using cxx standard version 14 made it go through, although there are still issues with gMock tests that I would really like to resolve. I'm not sure if the errors are related to a similar cxx standard mismatch issue, or if the LAME library or other dependencies are causing tests to fail. Does anyone have any tips on how to debug or satisfy the following tests?Dockerfile
gMock output
The text was updated successfully, but these errors were encountered: