pkg_tar stamp default value is inconsistent with documentation

[alokpr]

According to pkg_tar documentation, the default value of stamp should be -1 (which makes perfect sense).
However the actual default value is 0 (which is inconvenient).

https://github.com/bazelbuild/rules_pkg/blob/0.5.1/pkg/docs/reference.md#pkg_tar
https://github.com/bazelbuild/rules_pkg/blob/0.5.1/pkg/pkg.bzl#L447

[aiuto]

//pkg/docs/reference.md is obsolete and should be removed.
The documentation is wrong. The default should be 0.
The current docs do show 0, but have other formatting problems.
https://github.com/bazelbuild/rules_pkg/blob/main/docs/latest.md

All fixed in #509.

[alokpr]

I see - thanks for clarifying.

A default value of 0 is inconvenient though and also inconsistent with other bazel targets like cc_binary: https://docs.bazel.build/versions/main/be/c-cpp.html#cc_binary.stamp

Is there any specific reason for choosing 0 as the default?

[aiuto]

0 is the default because that causes the least surprise because it only impacts pieces of your build where you have enabled it

[aiuto]

Fixed in #509