Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using buildifier #99

Open
hochhaus opened this issue Jun 24, 2016 · 3 comments
Open

Consider using buildifier #99

hochhaus opened this issue Jun 24, 2016 · 3 comments

Comments

@hochhaus
Copy link
Contributor

As a feature request, rules_closure could consider using buildifier to format internal BUILD files.

https://github.com/bazelbuild/buildifier

@jart
Copy link
Contributor

jart commented Jun 24, 2016

+1

I've already been using buildifier this whole time. It's integrated into emacs and eclipse internally at Google.

The question is: how do we enforce it in CI? Hey @damienmg there's no such thing as METADATA presubmits in the Bazel world. We obviously don't want to have a rule in every single one of our dozens of BUILD files to make them validate themselves. What do we do?

@davidzchen
Copy link
Member

The closest thing to our METADATA presubmit hooks would probably be the Git precommit hook.

@damienmg
Copy link
Contributor

We will add this a test job to ci.bazel.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants