-
-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow nogo to run against all dependencies #4241
Comments
Woopsydaisy I just noticed this is actually a Bug :D When I run nogo with the default setting, nothing will be reported.
As soon as I change it to a config that includes third_party dependencies, it shows me the deprecation notices that the analyzers should have caught.
Turns out, nogo currently ignores all calls to third party code? |
Some nogo analyzers may require data collected from third-party packages to be effective. We could make it so that they still run, just don't warn or fail, but that would need knowing which ones these are. I'm not familiar enough with nogo to suggest something. |
I would suggest to use the |
As discussed via Slack, I would like to have a way to get the old behavior back. I am using bzlmod and would like to tell nogo to run against all third_party code
The text was updated successfully, but these errors were encountered: