Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NumPy v2.0 #266

Open
matt-graham opened this issue Jan 27, 2025 · 2 comments · May be fixed by #267
Open

Add support for NumPy v2.0 #266

matt-graham opened this issue Jan 27, 2025 · 2 comments · May be fixed by #267
Labels
enhancement New feature or request

Comments

@matt-graham
Copy link
Collaborator

We currently pin our NumPy dependency to <2:

s2fft/pyproject.toml

Lines 29 to 30 in 876e090

dependencies = [
"numpy>=1.20,<2",

This is problematic for users relying on other packages requiring NumPy 2 or above.

@matt-graham matt-graham added the enhancement New feature or request label Jan 27, 2025
@matt-graham
Copy link
Collaborator Author

From a quick check of trying to install s2fft in a fresh Python 3.12 environment with the upper NumPy version constraint removed, it looks like a blocker for now is that there does not appear to be a NumPy v2.0 compataible pyssht release on PyPI - astro-informatics/ssht#75 should have made such a release possible, but it looks like the last release on PyPI was in March 2023.

@matt-graham matt-graham linked a pull request Jan 27, 2025 that will close this issue
@jasonmcewen
Copy link
Contributor

Yes, see further discussion in PR 267 here.

Mayeul had been maintaining that but I don't think he's had time lately.

Do you know how do to that @matt-graham ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants