Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up by mypyc transpilation #51

Open
nstarman opened this issue Sep 21, 2023 · 5 comments
Open

Speed up by mypyc transpilation #51

nstarman opened this issue Sep 21, 2023 · 5 comments

Comments

@nstarman
Copy link
Collaborator

https://mypyc.readthedocs.io/en/latest/introduction.html#introduction

Requires type hinting

@asmeurer
Copy link
Owner

Is the performance bad? I would expect most of the time is spent in pyflakes. Maybe ruff can be used instead to provide a boost. Does it expose all the necessary information?

@nstarman
Copy link
Collaborator Author

People at Astropy have noticed it's the slowest step in our pre-commit.

@nstarman
Copy link
Collaborator Author

I'm not sure about ruff's python API. But that would presumably be much faster

@asmeurer
Copy link
Owner

They don't have one yet, but using it as a subprocess may be fast enough. astral-sh/ruff#659

@asmeurer
Copy link
Owner

Also would be a good idea to profile this to see if that actually is why it's slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants