You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
GOBIN is not set when install default-golang-pkgs. and thus go install new binaries into current version of go's GOBIN instead of new GOBIN.
To Reproduce
Steps to reproduce the behavior:
asdf install golang 1.24rc2
check $(env ASDF_GOLANG_VERSION=1.24rc2 go env GOBIN)
the directory ~/.asdf/installs/golang/1.24rc2/bin does not exists
current version of golang insall's GOBIN is updated. for example i'm using 1.23.5 for now, binaries inside .asdf/installs/golang/1.23.5/bin are updated
Expected behavior
asdf install golang VERSION should install binaries into ~/.asdf/installs/golang/$VERSION/bin
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
after some investigation, GOBIN is set for each go version since 962a601 , but not used in install scripts. add GOROOT="$ASDF_INSTALL_PATH/go" GOPATH="$ASDF_INSTALL_PATH/packages" PATH="$go_path:$PATH" go env GOBIN in install script will show that the GOBIN directory does not match the new installed version
Previously, when GOBIN was empty, default packages listed in
$ASDF_GOLANG_DEFAULT_PACKAGES_FILE were installed to
$ASDF_INSTALL_PATH/packages/bin. This could cause confusion,
as user-installed binaries might end up in different locations.
This commit ensures that GOBIN is always set, so all binaries
are consistently installed into $ASDF_INSTALL_PATH/bin.
Additionally, the use of $ASDF_INSTALL_PATH/packages/bin is
deprecated to prevent inconsistencies.
Closesasdf-community#151
Signed-off-by: Marko Kungla <[email protected]>
Describe the bug
GOBIN is not set when install default-golang-pkgs. and thus go install new binaries into current version of go's GOBIN instead of new GOBIN.
To Reproduce
Steps to reproduce the behavior:
$(env ASDF_GOLANG_VERSION=1.24rc2 go env GOBIN)
~/.asdf/installs/golang/1.24rc2/bin
does not exists.asdf/installs/golang/1.23.5/bin
are updatedExpected behavior
asdf install golang VERSION should install binaries into ~/.asdf/installs/golang/$VERSION/bin
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
after some investigation, GOBIN is set for each go version since 962a601 , but not used in install scripts. add
GOROOT="$ASDF_INSTALL_PATH/go" GOPATH="$ASDF_INSTALL_PATH/packages" PATH="$go_path:$PATH" go env GOBIN
in install script will show that the GOBIN directory does not match the new installed versionsuggest: add GOBIN in bin/install like this:
The text was updated successfully, but these errors were encountered: