Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items without market price are posted with squared qualityMultiplier #17

Open
jasongdove opened this issue May 20, 2024 · 0 comments
Open

Comments

@jasongdove
Copy link

jasongdove commented May 20, 2024

Quality multiplier is applied here for items without market price

if (price == 0) {
price = 10000000 * qualityMultiplier;
}

and here for all items

newItem.buyout = uint32(price * stackSize * qualityMultiplier);
newItem.bid = uint32(bidPrice * stackSize * qualityMultiplier);

I don't think this is intended; is it a bug? Perhaps the items without market price should just use nator->config->sellerConfig.defaultPrice without qualityMultiplier since it's applied later. Or, maybe don't multiply items that have market prices, i.e.

newItem.buyout = uint32(price * stackSize);
newItem.bid = uint32(bidPrice * stackSize);

I could see either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant