Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot set persistent volume claim storage size for FE #304

Open
2 of 3 tasks
geoffreytran opened this issue Nov 29, 2024 · 2 comments
Open
2 of 3 tasks

[Bug] Cannot set persistent volume claim storage size for FE #304

geoffreytran opened this issue Nov 29, 2024 · 2 comments
Assignees

Comments

@geoffreytran
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

Version

24.1.0

What's Wrong?

Currently cannot set the persistent volume claim storage size for FE as any value configured other than 100Gi get's set to 100Gi.

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License.  You may obtain a copy of the License at
#
#   http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied.  See the License for the
# specific language governing permissions and limitations
# under the License.

apiVersion: disaggregated.cluster.doris.com/v1
kind: DorisDisaggregatedCluster
metadata:
  name: test-disaggregated-cluster
spec:
  metaService:
    image: selectdb/doris.ms-ubuntu:3.0.2
    configMaps:
      - name: ms-configmap
    fdb:
      # address: ${fdb_endpoint}
      configMapNamespaceName:
        name: ${fdb-configmap}
        namespace: ${fdb-namespace}
  feSpec:
    replicas: 2
    image: selectdb/doris.fe-ubuntu:3.0.2
    persistentVolume:
      # logNotStore: true
      persistentVolumeClaimSpec:
      # storageClassName: ${storageclass_name}
        accessModes:
          - ReadWriteOnce
        resources:
          requests:
            storage: 10Gi
  computeGroups:
    - uniqueId: cg1
      replicas: 3
      image: selectdb/doris.be-ubuntu:3.0.2
      persistentVolume:
        # logNotStore: true
        persistentVolumeClaimSpec:
          # storageClassName: ${storageclass_name}
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: 100Gi
    - uniqueId: cg2
      replicas: 3
      image: selectdb/doris.be-ubuntu:3.0.2
      persistentVolume:
        # logNotStore: true
        persistentVolumeClaimSpec:
          # storageClassName: ${storageclass_name}
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: 100Gi

10Gi gets interpreted as 100Gi.

  feSpec:
    replicas: 2
    image: selectdb/doris.fe-ubuntu:3.0.2
    persistentVolume:
      # logNotStore: true
      persistentVolumeClaimSpec:
      # storageClassName: ${storageclass_name}
        accessModes:
          - ReadWriteOnce
        resources:
          requests:
            storage: 100Gi

What You Expected?

Expect storage size to match configured value of persistent volume claim template.

How to Reproduce?

No response

Anything Else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@geoffreytran
Copy link
Author

This appears to be due to the following lines that require the PVC to be 100Gi or greater. Suggest allowing smaller volume sizes for smaller/test deployments.

https://github.com/apache/doris-operator/blame/e45a51aad7e9d413a318cfb7b3708537bd62e51b/pkg/controller/sub_controller/disaggregated_cluster/disaggregated_fe/statefulset.go#L182-L184

@catpineapple
Copy link
Contributor

This limitation is due to the configuration of setting pvc storage to apply to both 'meta' and 'log', which have different upper and lower limits. I will modify the strategy here to allow free definition of meta and limit the size of log.

@catpineapple catpineapple self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants