Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d2lang syntax highlighting #36

Open
avelino opened this issue Jan 3, 2023 · 3 comments
Open

d2lang syntax highlighting #36

avelino opened this issue Jan 3, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@avelino
Copy link

avelino commented Jan 3, 2023

we need to give syntax highlighting support to the d2 language, the other editor versions that are on the official language site have color support (editor support)

when forcing d2-mode loading on open d2-file
Screenshot 2023-01-03 at 20 00 39

@andorsk
Copy link
Owner

andorsk commented Jan 5, 2023

thanks @avelino! I'll try to get to that this week!

@andorsk andorsk self-assigned this Jan 5, 2023
@andorsk
Copy link
Owner

andorsk commented Jan 7, 2023

@avelino thanks for the comments. Finally getting to it this weekend.

Seems like there are two issues bundled in this. re: syntax highlighting, I believe we already support this?

https://github.com/andorsk/d2-mode/blob/main/d2-mode.el#L92

image

Is the issue that there's inconsistency between syntax highlighting across d2 editors? I can see about lining it up more with the vim package https://github.com/terrastruct/d2-vim/blob/master/syntax/d2.vim if that's the right direction to go.

@andorsk
Copy link
Owner

andorsk commented Jan 7, 2023

re: opening the d2-mode opening a d2 file, I haven't been able to recreate the issue. Can anyone else recreate it?

image

It's possible you're running an old version of d2-mode? Melpa stable might be old. We might need to upgrade the tag to make sure people get the latest version.

Once I get #30 done, I'll probably upgrade the patch tag.

@andorsk andorsk added the enhancement New feature or request label Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants