Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP preview button seems to show duplicate logo when AMP sidebar is pinned #5943

Closed
westonruter opened this issue Mar 4, 2021 · 3 comments
Closed
Labels
Bug Something isn't working

Comments

@westonruter
Copy link
Member

Bug Description

In Transitional/Reader modes, there is an AMP preview button that is separate from the regular Preview button. Additionally, as of #5589 there is a new plugin sidebar for displaying validation errors. When that sidebar is pinned, the result is an apparent duplication of the AMP buttons in the toolbar:

image

Granted we want to eliminate the separate AMP preview button in favor of adding an AMP item to the Preview dropdown, but this is blocked by WordPress/gutenberg#25309. Nevertheless, I wanted to point it out as a potential source of user confusion in the meantime.

The resolution for this issue may be wontfix.

Expected Behaviour

The AMP logo should not appear multiple times in the toolbar.

Steps to reproduce

  1. Activate Reader or Transitional mode.
  2. Edit a post.
  3. Pin the AMP plugin sidebar
  4. See two logos in the toolbar

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter westonruter added the Bug Something isn't working label Mar 4, 2021
@simison
Copy link

simison commented Mar 15, 2021

There's a draft PR to add the capability in Gutenberg WordPress/gutenberg#25430

@westonruter Would anyone from the AMP team be up for helping to wrap that PR up? It seems so close! 😅

@westonruter
Copy link
Member Author

westonruter commented Mar 15, 2021

@delawski Is WordPress/gutenberg#25430 something you can take up?

@delawski
Copy link
Collaborator

@westonruter @simison I'll have a look and see what I can do about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants