Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not all commands require root #3

Closed
tippfehlr opened this issue Dec 13, 2023 · 5 comments
Closed

not all commands require root #3

tippfehlr opened this issue Dec 13, 2023 · 5 comments

Comments

@tippfehlr
Copy link
Contributor

Hi, I’d like to package this for the AUR.
Would it be possible to generate the shell files without root?
Not every command needs root, and running wrestic --help should also work without root.

@alvaro17f
Copy link
Owner

alvaro17f commented Dec 15, 2023

Hi @tippfehlr,
You're right, I want to improve this, but at this moment I don't have the time.
In a near future I'll be deploying a new version with this improvement. I have been already working on this.
It would be great to see Wrestic on AUR.

EDIT: I've just seen that you've already packaged It for AUR, thank you.

@tippfehlr
Copy link
Contributor Author

Take your time :)

I've just seen that you've already packaged It for AUR, thank you.

Yes, without shell completions for now.

@alvaro17f
Copy link
Owner

Good news!

@tippfehlr sudo has been removed for version 1.5.0.
You'll be prompted if needed.

Talking about completions, fish has been added.
For bash, now completions are stored inside home (just like fish).
Not yet for zsh, but you'll be prompted as well.

Thank you!

@tippfehlr
Copy link
Contributor Author

Thanks!
I hope you don’t mind that I’ve submitted another solution for completions in #6. I think it is more standard (used by rustup, for example) than your version and is easier to use in scripts.
Here is a description how to use wrestic completions as a user.

If that’s ok I would like to wait for #5 and #6 to be merged before releasing it.

@tippfehlr
Copy link
Contributor Author

@alvaro17f I don’t know if GitHub sends notifications for closed PRs ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants