Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker-yaml: contains unsafe, unused function #5733

Closed
dimovpetar opened this issue Jan 29, 2025 · 1 comment
Closed

worker-yaml: contains unsafe, unused function #5733

dimovpetar opened this issue Jan 29, 2025 · 1 comment
Labels
bug effort/small needs-triage p2

Comments

@dimovpetar
Copy link
Contributor

Describe the bug

worker-yaml.js contains unused and unsafe constructJavascriptFunction function.

Expected Behavior

Such unsafe and unused function is not part of the built code.

Current Behavior

Code analyzing tools detect this as potential problem, as it is not CSP compliant.

Reproduction Steps

Look at your latest build:

https://github.com/ajaxorg/ace-builds/blob/9ce7fb79ceb84db4e1421a2e972c5f84d0f95d95/src/worker-yaml.js#L4543

Possible Solution

No response

Additional Information/Context

No response

Ace Version / Browser / OS / Keyboard layout

1.36.5
@nightwing nightwing mentioned this issue Jan 30, 2025
Merged
@nlujjawal
Copy link
Contributor

nlujjawal commented Feb 3, 2025 •
edited
Loading

@nightwing can you confirm if the fix for this issue is merged with PR #5735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug effort/small needs-triage p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nightwing @dimovpetar @nlujjawal