Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency tree for stylelint 14.0.1 #65

Open
ronilaukkarinen opened this issue Nov 2, 2021 · 13 comments
Open

Update dependency tree for stylelint 14.0.1 #65

ronilaukkarinen opened this issue Nov 2, 2021 · 13 comments

Comments

@ronilaukkarinen
Copy link

It seems dependencies are outdated. Please update.

npm ERR! Could not resolve dependency:
npm ERR! peer stylelint@"^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0" from [email protected]
@JustFly1984
Copy link

please update

@ronilaukkarinen
Copy link
Author

It seems @YozhikM is not very active on GitHub nowadays. Please note that I have created a fork that works:

npm install @ronilaukkarinen/stylelint-a11y --save-dev

@NishaJKulal
Copy link

Even I am facing this issue.

@thibaudcolas
Copy link
Contributor

For people following this discussion – there’s now talks of either adding some of those rules to Stylelint itself or creating another community plugin similar to stylelint-a11y here: stylelint/stylelint#6212.

@ronilaukkarinen it’d be great to get your thoughts on this in particular!

@ronilaukkarinen
Copy link
Author

Thanks for the ping @thibaudcolas, I'll add my two cents.

ferdnyc added a commit to ferdnyc/yari that referenced this issue Mar 20, 2023
YozhikM/stylelint-a11y appears to be abandoned[1], and doesn't
support stylelint versions past 13.0.0. GitHub user
@ronilaukkarinen has created a fork to provide compatibility
with newer stylelint releases.

[1]: YozhikM/stylelint-a11y#65
@christian-weiss
Copy link

Conclusion:
stylelint-a11y is not moved to stylelint (core) and accessability will remain a plugin as decided here: stylelint/stylelint#6212.

Meantime YozhikM/stylelint-a11y was forked multiple times.

As of now https://github.com/mechanical-ink/stylelint-a11y is not yet available as package on nodejs.com.

The following seams to be active (recent activity):
@ronilaukkarinen/stylelint-a11y
@double-great/stylelint-a11y
Based on number of downloads, looks like community prefers https://www.npmjs.com/package/@ronilaukkarinen/stylelint-a11y

@christian-weiss
Copy link

/CLOSE

@carlosjeurissen
Copy link

carlosjeurissen commented Dec 21, 2023

@christian-weiss Thanks for your investigation! Both @ronilaukkarinen/stylelint-a11y and @double-great/stylelint-a11y seem incompatible with stylelint 16. Do you know if the one from @mechanical-ink is compatible with stylelint 16?

@YozhikM are you willing to add additional people to the npm package (https://www.npmjs.com/package/stylelint-a11y) so development can be taken over?

@ronilaukkarinen What are your thoughts on this going forward?

@ronilaukkarinen
Copy link
Author

@ronilaukkarinen What are your thoughts on this going forward?

I can update it asap.

@ronilaukkarinen
Copy link
Author

Updated. 16 support in v1.2.8.

@carlosjeurissen
Copy link

@ronilaukkarinen Thanks! When using it with stylelint 16, I still get the following error: Must use import to load ES Module: /[email protected]/node_modules/stylelint/lib/utils/isStandardSyntaxRule.mjs

@mechanical-ink and @double-great can we agree on one single repository for maintaining this dependency going forward?

@ronilaukkarinen
Copy link
Author

ronilaukkarinen commented Dec 21, 2023

Hmm, somehow my tests didn't cause any errors. Going to take another look at it.

As for the other discussion, we're having the same in several issues. My take is here (tl;dr; I'm going to keep maintaining my own fork regardless).

@ronilaukkarinen
Copy link
Author

Forced to revert back for the time being, see this. v1.2.9 out. Let's continue the discussion in their proper issues.

spaceninja added a commit to spaceninja/stylelint-config-spaceninja that referenced this issue Jan 4, 2024
This plugin is no longer maintained, and I found I was disabling one
of the three rules it added most of the time.
@see YozhikM/stylelint-a11y#65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants