Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Account settings on to separate screen #26

Closed
5 tasks done
iandunn opened this issue Dec 7, 2022 · 3 comments
Closed
5 tasks done

Move Account settings on to separate screen #26

iandunn opened this issue Dec 7, 2022 · 3 comments
Assignees
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Dec 7, 2022

I think it would make sense to split the "Account" subsection that has Email/Password onto a new tab, and list that along with 2FA on that page.
#15 (comment)

Breaking this off of #15 since it's a distinct task, and something that needs to be done in the wporg-support theme.

@iandunn iandunn added this to the MVP milestone Dec 7, 2022
@iandunn iandunn self-assigned this Dec 7, 2022
bazza pushed a commit to WordPress/wordpress.org that referenced this issue Dec 13, 2022
This commits the parts of #114 that don't affect production users, and can therefore be deployed now. Adding a link to this screen and removing the email/password settings from the built-in Edit screen will needs to wait until the WPORG Two Factor UI is done.

The rewrite rule was added in `r19711-dotorg`.

See WordPress/wporg-two-factor#26


git-svn-id: https://meta.svn.wordpress.org/sites/trunk@12321 74240141-8908-4e6f-9713-ba540dce6ec7
@iandunn iandunn modified the milestones: MVP, Iteration 1 Dec 13, 2022
@dd32
Copy link
Member

dd32 commented Dec 14, 2022

FYI; If we're splitting the "Account details" onto a new tab in bbPress (Which I didn't think we were going to do, MVP and all) then we'll also need to take into account Rosetta forums where these details can be managed too: https://fr.wordpress.org/support/users/profile/edit/

If we're creating a whole new Email/Password UI in addition to the 2FA UI then we might as well move it to profiles.w.org, since there's very little dependency upon bbPress then..
The main reason for me saying profiles was a no-go was that we'd have to create our own Email/Password UI in addition to the 2FA UI. We can come back to this discussion later though, as the JS will work on either page.

@iandunn iandunn modified the milestones: Iteration 1, MVP Dec 14, 2022
@iandunn
Copy link
Member Author

iandunn commented Dec 14, 2022

🤔 ah, ok, i didn't realize that was the reason. Given that, it does seem like moving straight to Profiles would be ideal, if there's time.

The main reason that I included password/etc was that it felt like the screen would be very disjointed if it was a mix of the bbPress UI and our custom UI. Maybe that's not really a concern though, if it won't be shown to users until its polished, which would give us time to move it to Profiles?

This was referenced Jan 30, 2023
bazza pushed a commit to WordPress/wordpress.org that referenced this issue Jan 31, 2023
@iandunn iandunn modified the milestones: MVP, Iteration 1 Feb 1, 2023
@iandunn
Copy link
Member Author

iandunn commented Sep 18, 2023

Done in r12896-meta and r20932-dotorg

@iandunn iandunn closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants