Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup Codes unintentionally regenerated when switching devices, clearing local storage, etc #244

Closed
iandunn opened this issue Sep 14, 2023 · 0 comments · Fixed by #245
Closed
Assignees
Labels
bug Something isn't working priority: high
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Sep 14, 2023

  1. Setup Backup Codes
  2. Delete the WPORG_2FA_HAS_BACKUP_CODES_BEEN_SAVED local storage item
  3. Refresh

Your original Backup Codes from step 1 will be regenerated. Step 2 artificially creates the situation, but the same thing should happen when viewing the screen from your phone when it was originally setup on your laptop, switching to a different browser, clearing your browser data, etc.

That was mentioned in #221, but I'm not sure the implications were obvious. When this happens it means that the codes that folks originally saved (maybe months or years prior) will be overwritten, and they'll have to save the new ones, or they risk being locked out of their account. At best that's annoying/inconvenient, but I worry that it'll create situations where folks didn't write down the new keys and lose their account.

@iandunn iandunn added bug Something isn't working priority: high labels Sep 14, 2023
@iandunn iandunn added this to the Iteration 1 milestone Sep 14, 2023
@iandunn iandunn self-assigned this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant